Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split telemetry container bucket #30481

Draft
wants to merge 2 commits into
base: integration
Choose a base branch
from
Draft

split telemetry container bucket #30481

wants to merge 2 commits into from

Conversation

yasmin-aumeeruddy
Copy link
Member

################################################################################################

Fixes #30480

@yasmin-aumeeruddy
Copy link
Member Author

yasmin-aumeeruddy commented Jan 6, 2025 •
edited by LibbyBot
Loading

#build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Jan 6, 2025

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 67 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 1 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • Please describe in a separate comment how you tested your changes.

@LibbyBot
Copy link

LibbyBot commented Jan 6, 2025

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_j2aXUMxQEe-f-sI4gb7_Pw

Target locations of links might be accessible only to IBM employees.

@yasmin-aumeeruddy
Copy link
Member Author

yasmin-aumeeruddy commented Jan 7, 2025 •
edited by LibbyBot
Loading

#build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Jan 7, 2025

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 67 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 1 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • Please describe in a separate comment how you tested your changes.

@LibbyBot
Copy link

LibbyBot commented Jan 7, 2025

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_sDxF8MziEe-f-sI4gb7_Pw

Target locations of links might be accessible only to IBM employees.

Azquelt
Azquelt reviewed Jan 7, 2025
View reviewed changes
...fat/fat/src/io/openliberty/microprofile/telemetry/internal/utils/jaeger/JaegerContainer.java
Comment on lines +36 to +38
public class JaegerContainer extends GenericContainer<JaegerContainer> {

private static final Class<?> c = JaegerContainer.class;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we're duplicating a lot of classes, particularly the utils package and the jaegertracing GRPC API.

It would be better to add these to a common project. I suspect we could fairly easily move them to io.openliberty.microprofile.telemetry.internal_fat.common.

@yasmin-aumeeruddy yasmin-aumeeruddy marked this pull request as draft January 7, 2025 16:01
@yasmin-aumeeruddy yasmin-aumeeruddy mentioned this pull request Jan 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Azquelt Azquelt Azquelt left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed noproductcode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split the MicroProfile Telemetry Container FAT bucket
3 participants
@yasmin-aumeeruddy @LibbyBot @Azquelt